Quellcode durchsuchen

[utils] Clarify for redirecting STDIN in get_exe_version()

Yen Chi Hsuan vor 9 Jahren
Ursprung
Commit
b64d04c119
1 geänderte Dateien mit 3 neuen und 0 gelöschten Zeilen
  1. 3 0
      youtube_dl/utils.py

+ 3 - 0
youtube_dl/utils.py

@@ -1818,6 +1818,9 @@ def get_exe_version(exe, args=['--version'],
     """ Returns the version of the specified executable,
     """ Returns the version of the specified executable,
     or False if the executable is not present """
     or False if the executable is not present """
     try:
     try:
+        # STDIN should be redirected too. On UNIX-like systems, ffmpeg triggers
+        # SIGTTOU if youtube-dl is run in the background.
+        # See https://github.com/rg3/youtube-dl/issues/955#issuecomment-209789656
         out, _ = subprocess.Popen(
         out, _ = subprocess.Popen(
             [encodeArgument(exe)] + args,
             [encodeArgument(exe)] + args,
             stdin=subprocess.PIPE,
             stdin=subprocess.PIPE,